Change in vdsm[master]: Moving coredump configuration to common script

Alon Bar-Lev alonbl at redhat.com
Mon Oct 7 12:33:55 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Moving coredump configuration to common script
......................................................................


Patch Set 2:

(2 comments)

....................................................
File init/daemonAdapter
Line 67:     def execute(self):
Line 68:         try:
Line 69:             self._parse_args()
Line 70:             os.nice(config.getint('vars', 'vdsm_nice'))
Line 71:             if os.environ['COREDUMP_ENABLED']:
this value is not reaching here.
Line 72:                 resource.setrlimit(resource.RLIMIT_CORE, 0)
Line 73: 
Line 74:             env = os.environ.copy()
Line 75:             env.update({


....................................................
File init/vdsmd_init_common.sh.in
Line 27:     local getconfitem="@VDSMDIR@/get-conf-item"
Line 28: 
Line 29:     if "${getconfitem}" "${conf_file}" vars core_dump_enable false |
Line 30:       tr A-Z a-z | grep -q true; then
Line 31:         export COREDUMP_ENABLED=True
this is not go into the damaemon anyway... just remove.
Line 32:         echo "/var/log/core/core.%p.%t.dump" > /proc/sys/kernel/core_pattern
Line 33:     fi
Line 34: }
Line 35: 


-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list