Change in vdsm[master]: Unified persistence [3/4] - Restore network config

ybronhei at redhat.com ybronhei at redhat.com
Mon Oct 7 11:58:59 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Unified persistence [3/4] - Restore network config
......................................................................


Patch Set 26:

(1 comment)

....................................................
File lib/vdsm/tool/restore_nets.py
Line 31:     Restores the networks to what was previously persisted via vdsm.
Line 32:     """
Line 33:     rc, out, err = utils.execCmd([os.path.join(
Line 34:         P_VDSM, 'vdsm-restore-net-config')], raw=True,
Line 35:         sudo=kwargs.get('sudo', False))
only root should run it anyway.. no?
Line 36:     sys.stdout.write(out)
Line 37:     sys.stderr.write(err)


-- 
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list