Change in vdsm[master]: image: Return the new volume after merge

abaron at redhat.com abaron at redhat.com
Mon Oct 7 11:48:18 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: image: Return the new volume after merge
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/storage/image.py
Line 1132:             self.log.error("Failure to remove subchain %s -> %s in image %s",
Line 1133:                            ancestor, successor, imgUUID, exc_info=True)
Line 1134: 
Line 1135:         try:
Line 1136:             srcVol.shrinkToOptimalSize()
wouldn't it be simpler and safer just to produce the new volume here? We just finished merging volumes so the overhead is negligible and this way we wouldn't care about any implementation changes above (also, it would be 1 line without changing internal APIs etc).
Line 1137:         except qemuImg.QImgError:
Line 1138:             self.log.warning("Auto shrink after merge failed", exc_info=True)
Line 1139: 
Line 1140:         self.log.info("Merge src=%s with dst=%s was successfully finished.",


-- 
To view, visit http://gerrit.ovirt.org/19883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b0969c3144b51ff22a7f5eb756563cf178ffb36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list