Change in vdsm[master]: Unified persistence [3/4] - Restore network config
ybronhei at redhat.com
ybronhei at redhat.com
Mon Oct 7 10:40:18 UTC 2013
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified persistence [3/4] - Restore network config
......................................................................
Patch Set 24:
(5 comments)
....................................................
File init/vdsmd_init_common.sh.in
Line 172: "$VDSM_TOOL" libvirt-test-conflicts
Line 173: }
Line 174:
Line 175: task_restore_nets(){
Line 176: RESTORATION_FILE="@VDSMRUNDIR@/nets_restored"
please change to:
local restoration_file=...
Line 177: if [ ! -f "$RESTORATION_FILE" ]; then
Line 178: "@PYTHON@" "@VDSMDIR@/vdsm-restore-net-config"
Line 179: touch "$RESTORATION_FILE"
Line 180: fi
Line 173: }
Line 174:
Line 175: task_restore_nets(){
Line 176: RESTORATION_FILE="@VDSMRUNDIR@/nets_restored"
Line 177: if [ ! -f "$RESTORATION_FILE" ]; then
use "${..}"
Line 178: "@PYTHON@" "@VDSMDIR@/vdsm-restore-net-config"
Line 179: touch "$RESTORATION_FILE"
Line 180: fi
Line 181: }
Line 175: task_restore_nets(){
Line 176: RESTORATION_FILE="@VDSMRUNDIR@/nets_restored"
Line 177: if [ ! -f "$RESTORATION_FILE" ]; then
Line 178: "@PYTHON@" "@VDSMDIR@/vdsm-restore-net-config"
Line 179: touch "$RESTORATION_FILE"
It can return a failure code.. don't you want to report it?
Line 180: fi
Line 181: }
Line 182: #### pre-start tasks end ####
Line 183:
....................................................
File vdsm/vdsm-restore-net-config
Line 65:
Line 66:
Line 67: if __name__ == '__main__':
Line 68: try:
Line 69: logging.config.fileConfig("/etc/vdsm/svdsm.logger.conf")
why supervdsm conf? use vdsm.logger.conf..
Line 70: except:
Line 71: logging.basicConfig(filename='/dev/stdout', filemode='w+',
Line 72: level=logging.DEBUG)
Line 73: logging.error("Could not init proper logging", exc_info=True)
Line 67: if __name__ == '__main__':
Line 68: try:
Line 69: logging.config.fileConfig("/etc/vdsm/svdsm.logger.conf")
Line 70: except:
Line 71: logging.basicConfig(filename='/dev/stdout', filemode='w+',
don't you prefer to use syslog as fallback?
Line 72: level=logging.DEBUG)
Line 73: logging.error("Could not init proper logging", exc_info=True)
Line 74:
--
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list