Change in vdsm[master]: Add IPv6 support to configNetwork

psebek at redhat.com psebek at redhat.com
Mon Oct 7 09:20:19 UTC 2013


Petr Šebek has posted comments on this change.

Change subject: Add IPv6 support to configNetwork
......................................................................


Patch Set 4:

(2 comments)

....................................................
File vdsm/netmodels.py
Line 407: class IpConfig(object):
Line 408:     ipConfig = namedtuple('ipConfig', ['ipaddr', 'netmask', 'gateway',
Line 409:                                        'defaultRoute', 'ipv6addr',
Line 410:                                        'ipv6gateway', 'ipv6defaultRoute',
Line 411:                                        'bootproto', 'async',  'ipv6autoconf',
Fixed
Line 412:                                        'dhcpv6'])
Line 413: 
Line 414:     def __init__(self, inet4=None, inet6=None, bootproto=None, blocking=False,
Line 415:                  ipv6autoconf=None, dhcpv6=None):


Line 411:                                        'bootproto', 'async',  'ipv6autoconf',
Line 412:                                        'dhcpv6'])
Line 413: 
Line 414:     def __init__(self, inet4=None, inet6=None, bootproto=None, blocking=False,
Line 415:                  ipv6autoconf=None, dhcpv6=None):
You are right that was the problem. Now I pass both configuration even if it has only None values.
Line 416:         if inet4 is None and inet6 is None:
Line 417:             raise ConfigNetworkError(ne.ERR_BAD_ADDR, 'You need to specify '
Line 418:                                      'IPv4 or IPv6 or both address.')
Line 419:         if ((inet4 and inet4.address and bootproto == 'dhcp') or


-- 
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek <psebek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Šebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list