Change in vdsm[master]: Tests: Fixed resource manager stress test
danken at redhat.com
danken at redhat.com
Mon Oct 7 01:12:33 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: Tests: Fixed resource manager stress test
......................................................................
Patch Set 5:
(2 comments)
....................................................
File tests/resourceManagerTests.py
Line 643: lockTranslator = [resourceManager.LockType.exclusive,
Line 644: resourceManager.LockType.shared]
Line 645:
Line 646: threads = []
Line 647: for i in range(procLimit/2):
hasn't pep-8 bitten you for no spaces around the / operator?
Line 648: t = threading.Thread(target=register)
Line 649: try:
Line 650: t.start()
Line 651: except:
Line 647: for i in range(procLimit/2):
Line 648: t = threading.Thread(target=register)
Line 649: try:
Line 650: t.start()
Line 651: except:
I was not clear earlier. here you catch any exception. Please limit yourself to the specific out-of-resources exception you are expecting.
Line 652: # Reached thread limit, bail out
Line 653: # Mark test as "maxedOut" which will be used later to make sure
Line 654: # we clean up without using threads.
Line 655: maxedOut = True
--
To view, visit http://gerrit.ovirt.org/19252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ba095724a251968c8d5b2767e6491825d79297e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list