Change in vdsm[master]: Removing libvirt_configure from pre-start and ask for manual...

danken at redhat.com danken at redhat.com
Sun Oct 6 18:20:32 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Removing libvirt_configure from pre-start and ask for manual run
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

other than the tabs, I'm happy with this patch.

....................................................
File init/vdsmd_init_common.sh.in
Line 219: 	    "
Line 220:         ;;
Line 221:     --post-stop)
Line 222:         run_tasks " \
Line 223: 	    run_final_hooks \
please replace the tabs.
Line 224: 	    "
Line 225:         ;;
Line 226:     --help|*)
Line 227:         usage


-- 
To view, visit http://gerrit.ovirt.org/19737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list