Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...

danken at redhat.com danken at redhat.com
Sun Oct 6 17:57:21 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Avoiding automatically restart of sanlock service when starting vdsmd
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

....................................................
File init/systemd/systemd-vdsmd.in
Line 28: 
Line 29: "@BINDIR@/vdsm-tool" libvirt-configure ${2:+--force} &&
Line 30:     "@BINDIR@/vdsm-tool" libvirt-configure-services-restart
Line 31: "@BINDIR@/vdsm-tool" sanlock-check-service &&
Line 32:     "@BINDIR@/vdsm-tool" service-restart sanlock
this is called by ovirt-host-deploy only on Fedora. For EL6 we must keep nasty restart on "reconfigure" verb.


....................................................
File init/vdsmd_init_common.sh.in
Line 218:         run_tasks " \
Line 219:             configure_coredump \
Line 220:             run_init_hooks \
Line 221:             gencerts \
Line 222:             check_libvirt_configure \
I think that the only change possible is to replace this with check_sanlock_configure
Line 223:             reconfigure_sanlock \
Line 224:             syslog_available \
Line 225:             nwfilter dummybr \
Line 226:             load_needed_modules \


Line 229:             test_conflicting_conf \
Line 230: 	    "
Line 231:         ;;
Line 232:     --post-stop)
Line 233:         run_tasks " \
how have these evil tabs got here?
Line 234: 	    run_final_hooks \
Line 235: 	    "
Line 236:         ;;
Line 237:     --help|*)


-- 
To view, visit http://gerrit.ovirt.org/19890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list