Change in vdsm[master]: Start issciadm tests - unfinished

amureini at redhat.com amureini at redhat.com
Sun Oct 6 09:57:32 UTC 2013


Allon Mureinik has posted comments on this change.

Change subject: Start issciadm tests - unfinished
......................................................................


Patch Set 2:

(1 comment)

....................................................
File tests/iscsiadmTests.py
Line 63: 
Line 64: class TestCommands(TestCaseBase):
Line 65: 
Line 66:     def setUp(self):
Line 67:         self.savedCmd = iscsiadm.misc.execCmd
why not just rebase this one on top of it?
Line 68:         self.cmd = iscsiadm.misc.execCmd = FakeExecCmd()
Line 69: 
Line 70:     def tearDown(self):
Line 71:         iscsiadm.misc.execCmd = self.savedCmd


-- 
To view, visit http://gerrit.ovirt.org/19856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ed21408c7b496c384053ce02cdb66d47df9a14b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list