Change in vdsm[master]: vdsm: Adding ppc64 handling to getVdsCaps

danken at redhat.com danken at redhat.com
Sat Oct 5 16:50:17 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Adding ppc64 handling to getVdsCaps
......................................................................


Patch Set 8:

(2 comments)

....................................................
File lib/vdsm/utils.py
Line 66: 
Line 67: 
Line 68: class Architecture:
Line 69:     X86_64 = 'x86_64'
Line 70:     PPC64 = 'ppc64'
Better postpone the definition to the same patch of usage. Only then we can tell if the module makes sense.
Line 71: 
Line 72: 
Line 73: class IOCLASS:
Line 74:     REALTIME = 1


....................................................
File tests/capsTests.py
Line 30:     def testCpuInfo(self):
Line 31:         testPath = os.path.realpath(__file__)
Line 32:         dirName = os.path.split(testPath)[0]
Line 33:         path = os.path.join(dirName, "cpu_info.out")
Line 34:         c = caps.CpuInfo('x86_64', path)
The path argument is the only for testing. I can take an extra arg to facilitate testing.

However, hopefully there's a cleaner way by monkeypatching platform.arch.
Line 35:         self.assertEqual(set(c.flags()), set("""fpu vme de pse tsc msr pae
Line 36:                                                 mce cx8 apic mtrr pge mca
Line 37:                                                 cmov pat pse36 clflush dts
Line 38:                                                 acpi mmx fxsr sse sse2 ss ht


-- 
To view, visit http://gerrit.ovirt.org/17437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list