Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
sbonazzo at redhat.com
sbonazzo at redhat.com
Fri Oct 4 13:01:58 UTC 2013
Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
......................................................................
Patch Set 1:
(1 comment)
....................................................
File client/vdsClient.py
Line 1694:
Line 1695: def startMonitoringDomain(self, args):
Line 1696: sdUUID, hostID = args
Line 1697: self.s.startMonitoringDomain(sdUUID, hostID)
Line 1698: return 0, ''
I would have expected something like:
status = self.s.startMonitoringDomain(sdUUID, hostID)
return status['status']['code'], status['status']['message']
with the above return 0, '' vdsClient will exit with status 0 also if the call fails, no?
Line 1699:
Line 1700: def stopMonitoringDomain(self, args):
Line 1701: sdUUID, = args
Line 1702: self.s.stopMonitoringDomain(sdUUID)
--
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list