Change in vdsm[master]: Enable VM migration to old vdsm's.

danken at redhat.com danken at redhat.com
Fri Oct 4 12:34:25 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Enable VM migration to old vdsm's.
......................................................................


Patch Set 2:

(1 comment)

Ayal, maybe I misunderstood the condition that worries you. If so, please re-explain it. I am a bit anxious to unbreak migration in ovirt-3.3 by promptly taking this patch.

....................................................
File vdsm/storage/blockSD.py
Line 1035:         try:
Line 1036:             os.symlink(imgPath, dst)
Line 1037:         except OSError as e:
Line 1038:             if e.errno == errno.EEXIST:
Line 1039:                 self.log.debug("img run dir already exists: %s", dst)
I tend to agree with Eduardo: the link source and destination contains the very same sdUUID. If someone called prepareImage() with sdUUID, we are bound to return a path to that domain, even though a newer image exists on another domain. In such a case, the bug exists higher in the stack, with whomever asked to prepare the image on the stale storage domain.
Line 1040:             else:
Line 1041:                 self.log.error("Failed to create img run dir: %s", dst)
Line 1042:                 raise
Line 1043:         return dst


-- 
To view, visit http://gerrit.ovirt.org/19825
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list