Change in vdsm[master]: image: Calculation of chain to remove is inaccurate

abaron at redhat.com abaron at redhat.com
Fri Oct 4 12:33:05 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: image: Calculation of chain to remove is inaccurate
......................................................................


Patch Set 1: Code-Review+2

I believe engine only ever passes a single volume so possibly it would be better to just remove the support for removal of subchain and significantly simplify the code.
This does not detract from the correctness of this patch though so +2.

-- 
To view, visit http://gerrit.ovirt.org/19852
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I248c51727584a35d1f439e57c93613caa9f369a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list