Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.

dgibson at redhat.com dgibson at redhat.com
Fri Oct 4 05:27:21 UTC 2013


David Gibson has posted comments on this change.

Change subject: supervdsm: Enable multiprocessing module logging.
......................................................................


Patch Set 3:

Changed 1 to True as requested.

I'm not sure what you mean "import only what needed".  What's being imported that's not needed?

I'm having trouble parsing the last paragraph of Yaniv's last comment.  But if I understand it correctly, it's not merely a question of altering multiprocessings logging configuration.  Unless multiprocessing.get_logger() is called at least once to instantiate the logger multiprocessing *will not log* at all, regardless of any other logger configuration.  So 17199 won't remove the necessity for this patch.

-- 
To view, visit http://gerrit.ovirt.org/19741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Gibson <dgibson at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list