Change in vdsm[master]: Enable VM migration to old vdsm's.

abaron at redhat.com abaron at redhat.com
Thu Oct 3 12:33:13 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Enable VM migration to old vdsm's.
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/storage/blockSD.py
Line 1035:         try:
Line 1036:             os.symlink(imgPath, dst)
Line 1037:         except OSError as e:
Line 1038:             if e.errno == errno.EEXIST:
Line 1039:                 self.log.debug("img run dir already exists: %s", dst)
is this the correct behaviour? shouldn't we overwrite it in this case? (in case the link is wrong)
Line 1040:             else:
Line 1041:                 self.log.error("Failed to create img run dir: %s", dst)
Line 1042:                 raise
Line 1043:         return dst


-- 
To view, visit http://gerrit.ovirt.org/19825
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list