Change in vdsm[master]: Removing libvirt_configure from pre-start and ask for manual...

danken at redhat.com danken at redhat.com
Thu Oct 3 12:28:30 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Removing libvirt_configure from pre-start and ask for manual run
......................................................................


Patch Set 2:

(2 comments)

....................................................
File init/sysvinit/vdsmd.init.in
Line 137
Line 138
Line 139
Line 140
Line 141
To say nothing about the usage of the global RETVAL. In a future patch, I hope.


....................................................
File init/vdsmd_init_common.sh.in
Line 205: case "$1" in
Line 206:     --pre-start)
Line 207:         run_tasks " \
Line 208:             run_init_hooks gencerts check_libvirt_configure \
Line 209:             reconfigure_sanlock syslog_available nwfilter dummybr \
Yeah, it has to be moved to 'reconfigure' which is called by host-deploy.
Line 210:             load_needed_modules tune_system mkdirs test_space test_lo \
Line 211:             test_conflicting_conf"
Line 212:         ;;
Line 213:     --post-stop)


-- 
To view, visit http://gerrit.ovirt.org/19737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list