Change in vdsm[master]: jsonrpc: Create the java bindings and fix bugs

ybronhei at redhat.com ybronhei at redhat.com
Wed Oct 2 10:29:20 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpc: Create the java bindings and fix bugs
......................................................................


Patch Set 5:

(4 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-02-07 15:26:39 -0500
Line 4: Commit:     Saggi Mizrahi <smizrahi at redhat.com>
Line 5: CommitDate: 2013-09-24 18:04:18 +0300
Line 6: 
Line 7: jsonrpc: Create the java bindings and fix bugs
Main change in scheme is about adding typemap field, please explain the motivation for that.
Line 8: 
Line 9: Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c


....................................................
File tests/jsonRpcUtils.py
Line 23:     pass
Line 24: 
Line 25: 
Line 26: def hasProton():
Line 27:     return protonReactor is not None
can't it raise a NameError if the import fails?
Line 28: 
Line 29: 
Line 30: def getFreePort():
Line 31:     sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)


....................................................
File vdsm.spec.in
Line 1228: %{_datadir}/%{vdsm_name}/BindingJsonRpc.py*
Line 1229: %{_datadir}/%{vdsm_name}/Bridge.py*
Line 1230: 
Line 1231: %files yajsonrpc
Line 1232: %{python_sitearch}/yajsonrpc/__init__.py*
Im not sure, but seems to me that it should stay under python_sitelib , as it is a site library
Line 1233: %{python_sitearch}/yajsonrpc/asyncoreReactor.py*
Line 1234: %{python_sitearch}/yajsonrpc/betterAsyncore.py*
Line 1235: %{python_sitearch}/yajsonrpc/protonReactor.py*
Line 1236: 


....................................................
File vdsm_api/vdsmapi.py
Line 116:     Find the API schema file whether we are running from within the source dir
Line 117:     or from an installed location
Line 118:     """
Line 119:     # Don't depend on module VDSM if not looking for schema
Line 120:     from vdsm import constants
from vdsm.constants import P_VDSM also enough
Line 121: 
Line 122:     localpath = os.path.dirname(__file__)
Line 123:     installedpath = constants.P_VDSM
Line 124:     for directory in localpath, installedpath:


-- 
To view, visit http://gerrit.ovirt.org/19497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list