Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Tue Oct 1 14:44:42 UTC 2013


Michal Skrivanek has posted comments on this change.

Change subject: vm: Pause vm in case volume allocation is greater than lv size
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/vm.py
Line 508:             capacity, alloc, physical = \
Line 509:                 self._vm._dom.blockInfo(vmDrive.path, 0)
Line 510: 
Line 511:             if physical - alloc < 0:
Line 512:                 self._vm.pause(pauseCode='EOTHER')
wouldn't EIO be more appropriate here?
Line 513:                 self._log.error('vm: %s paused due to the corrupt volume: %s',
Line 514:                                 self._vm.id, vmDrive.path)
Line 515:                 continue
Line 516: 


-- 
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list