Change in vdsm[master]: Manage and fix test dummies handling -> module level

danken at redhat.com danken at redhat.com
Tue Oct 1 10:49:33 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Manage and fix test dummies handling -> module level
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

Thanks for the rebase.

....................................................
File tests/functional/networkTests.py
Line 1258:                 self.assertFalse(ruleExists(rule))
Line 1259:                 ruleAdd(rule)
Line 1260:                 self.assertTrue(ruleExists(rule))
Line 1261:                 ruleDel(rule)
Line 1262:                 self.assertFalse(ruleExists(rule))
now that you've explained why this is required, I can tell that it should sit in a "finally" clause of a "try" block starting after the setIP command.
Line 1263:             addrFlush(nic)
Line 1264: 
Line 1265:     @RequireDummyMod
Line 1266:     @ValidateRunningAsRoot


-- 
To view, visit http://gerrit.ovirt.org/19650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list