Change in vdsm[master]: getStorageDomainInfo: SP keys when disconnected.

fsimonce at redhat.com fsimonce at redhat.com
Thu Nov 28 14:29:23 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: getStorageDomainInfo: SP keys when disconnected.
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/storage/hsm.py
Line 2726:         # getSharedLock(connectionsResource...)
Line 2727: 
Line 2728:         vars.task.getSharedLock(STORAGE, sdUUID)
Line 2729:         info = dom.getInfo()
Line 2730:         # This only occurred because someone
+1 to remove this all.
Line 2731:         # thought it would be clever to return pool
Line 2732:         # information in the domain.getInfo() method
Line 2733:         # In a perfect world I would have just stopped
Line 2734:         # giving this information in the response.


-- 
To view, visit http://gerrit.ovirt.org/19555
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Aharon Canan <aharonca at gmail.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list