Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage

dougsland at redhat.com dougsland at redhat.com
Thu Nov 28 12:58:42 UTC 2013


Hello Yaniv Bronhaim, mooli tayer, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/21830

to review the following change.

Change subject: vdsm.spec: conditional to execute semanage
......................................................................

vdsm.spec: conditional to execute semanage

To avoid load policy when selinux is disabled, only
execute semanage when selinux is enabled.

Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21432
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: mooli tayer <mtayer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/21830/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 08119d9..147bf3f 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -649,8 +649,11 @@
 fi
 
 # hack until we replace core dump with abrt
-/usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
+if /usr/sbin/selinuxenabled; then
+    /usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
+fi
 /sbin/restorecon -R -v /var/log/core
+# hack until we replace core dump with abrt
 
 %if 0%{?rhel}
 if [ "$1" -eq 1 ] ; then


-- 
To view, visit http://gerrit.ovirt.org/21830
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>


More information about the vdsm-patches mailing list