Change in vdsm[master]: vdsm.spec: conditional to execute semanage

mtayer at redhat.com mtayer at redhat.com
Thu Nov 28 11:57:32 UTC 2013


mooli tayer has posted comments on this change.

Change subject: vdsm.spec: conditional to execute semanage
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

....................................................
File vdsm.spec.in
Line 657: # hack until we replace core dump with abrt
Line 658: if /usr/sbin/selinuxenabled; then
Line 659:     /usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
Line 660: fi
Line 661: /sbin/restorecon -R -v /var/log/core
Sorry a bit busy. Two issue:

1.) a problem with my original patch - If the dir does not exist
restorecon will complain. not sure it is related to this patch.

2.) if user installs at point a then selinux enables at point b
he will not have selinux permissions. 

for now I'm giving +1.
In the long run i'm think we should do what Dan wanted
and replace with abrt.

I hope to get back to it next week and will appreciate help
If someone feels like joining in;
http://gerrit.ovirt.org/#/c/20751/
Line 662: # hack until we replace core dump with abrt
Line 663: 
Line 664: %if 0%{?rhel}
Line 665: if [ "$1" -eq 1 ] ; then


-- 
To view, visit http://gerrit.ovirt.org/21432
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list