Change in vdsm[master]: vdsm.spec: conditional for hostname require

danken at redhat.com danken at redhat.com
Wed Nov 27 23:41:54 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: conditional for hostname require
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

....................................................
File vdsm/gluster/hostname.py.in
Line 20: 
Line 21: from vdsm import utils
Line 22: 
Line 23: _hostNameCommandPath = utils.CommandPath("hostname",
Line 24:                                          "@HOSTNAME_PATH@",
The whole point of utils.CommandPath is to avoid these ugly-and-complex .py.in files. We should not keep utils.CommandPath if we're using autoconf to find the path. Drop _hostNameCommandPath.cmd and replace it with "@HOSTNAME_PATH@".

Please take the simpler way of adding another optional path. I'm pretty sure that Federico would have been even more adamant about it than I am.
Line 25:                                          )
Line 26: 
Line 27: 
Line 28: class HostNameException(Exception):


-- 
To view, visit http://gerrit.ovirt.org/21194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Cole Robinson <aintdiscole at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list