Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 27 17:58:32 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: bootstrap: Return recovery error during lvm bootstrap
......................................................................


Patch Set 4:

(1 comment)

....................................................
File vdsm/storage/hsm.py
Line 373:         def storageRefresh():
Line 374:             try:
Line 375:                 lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS)
Line 376:             finally:
Line 377:                 self._ready = True
Setting _ready at the end of the thread is reasonable, but I must keep the try finally, otherwise we are left with a zombee vdsm.

Since errors in this thread were never handled, I'm not going to handle them in this patch.
Line 378:                 self.log.debug("HSM is ready")
Line 379: 
Line 380:             sdCache.refreshStorage()
Line 381: 


-- 
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list