Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
nsoffer at redhat.com
nsoffer at redhat.com
Wed Nov 27 16:51:09 UTC 2013
Nir Soffer has posted comments on this change.
Change subject: bootstrap: Return recovery error during lvm bootstrap
......................................................................
Patch Set 4:
(1 comment)
....................................................
File vdsm/clientIF.py
Line 108: self._prepareBindings()
Line 109:
Line 110: @property
Line 111: def ready(self):
Line 112: return (self.irs is None or self.irs.ready) and not self._recovery
You will not get attribute error since ready is not accessed from __init__ and as soon as _initIRS is called irs attribute exists.
I agree that we should have a self.irs = None in init, and actually there is no point in _initIRS - it should be inlined in __init__, but I don't want to add unrelated changes here.
Line 113:
Line 114: def contEIOVms(self, sdUUID, isDomainStateValid):
Line 115: # This method is called everytime the onDomainStateChange
Line 116: # event is emitted, this event is emitted even when a domain goes
--
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list