Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

asegurap at redhat.com asegurap at redhat.com
Wed Nov 27 09:30:13 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: vdsm: allow hooks to pass down dictionaries in json format
......................................................................


Patch Set 4:

(1 comment)

Overall looks good to me, but needs a semantic change in the "after" hook.

....................................................
File vdsm/configNetwork.py
Line 627:                                get('bonding') in bondings)
Line 628:                 raise ConfigNetworkError(ne.ERR_LOST_CONNECTION,
Line 629:                                          'connectivity check failed')
Line 630: 
Line 631:     hooks.after_network_setup({'networks': dict(networks),
The information passed down should be the new RunningConfig. (That would mean this hook is only for unified persistence, but I'm fine with that).
Line 632:                                'bondings': dict(bondings),
Line 633:                                'options': dict(options)})
Line 634: 
Line 635: 


-- 
To view, visit http://gerrit.ovirt.org/20330
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07c511e9740fd19a1c27baf87e91f9a427d0dcd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel at ajo.es>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel at ajo.es>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list