Change in vdsm[master]: vm: Fix vm unpausing during recovery

danken at redhat.com danken at redhat.com
Tue Nov 26 22:10:52 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: Fix vm unpausing during recovery
......................................................................


vm: Fix vm unpausing during recovery

Domain monitor thread was not reporting when going from unknown state to
known state. The thread would start with a bogus valid state, before
checking the domain. If the first domain check found the domain as
valid, no notification was emitted. If there were paused vms while
connecting to the pool, they were not unpaused as they should.

This patch fix various modules:

- Domain monitor status lastCheck is initialized now to special
  NOT_CHECKED_YET value. The monitor thread use this value to detect the
  first sample, and emit the missing notification.

- To get the new event when monitor thread starts, domain state change
  are registered now *before* the monitor threads are started.

- To get the vm unpause code to work in recovery mode, the Vm.sdIds is
  initialized in Vm._run. This probably fixes other issues with
  recovered vms.

Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e
Bug-Url: https://bugzilla.redhat.com/1003588
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21649
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/storage/domainMonitor.py
M vdsm/storage/hsm.py
M vdsm/vm.py
3 files changed, 19 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Verified
  Federico Simoncelli: Looks good to me, approved
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/21649
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list