Change in vdsm[master]: vdsm: refactor buildConfDevices and getConfDevices into sing...

mpoledni at redhat.com mpoledni at redhat.com
Tue Nov 26 12:07:12 UTC 2013


Martin Polednik has posted comments on this change.

Change subject: vdsm: refactor buildConfDevices and getConfDevices into single function
......................................................................


Patch Set 5: Verified+1

(1 comment)

....................................................
File vdsm/vm.py
Line 1913:         for drv in devices[DISK_DEVICES]:
Line 1914:             if isVdsmImage(drv):
Line 1915:                 self._normalizeVdsmImg(drv)
Line 1916: 
Line 1917:         self.normalizeDrivesIndices(devices[DISK_DEVICES])
correct
Line 1918: 
Line 1919:         # Preserve old behavior. Since libvirt add a memory balloon device
Line 1920:         # to all guests, we need to specifically request not to add it.
Line 1921:         self._normalizeBalloonDevice(devices[BALLOON_DEVICES])


-- 
To view, visit http://gerrit.ovirt.org/19348
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3a209967f97a55fe861c4446e8f93e1a1da08e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list