Change in vdsm[master]: Optimize netinfo.py:get()

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 25 21:33:20 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: Optimize netinfo.py:get()
......................................................................


Patch Set 2:

(1 comment)

....................................................
File lib/vdsm/netinfo.py
Line 522:             'cfg': getIfaceCfg(dev),
Line 523:             'ipv6addrs': ipv6addrs,
Line 524:             'mtu': str(getMtu(dev)),
Line 525:             'netmask': ipv4netmask}
Line 526: 
Why all those _devinfo functions not part of the Link class?
Line 527: 
Line 528: def get():
Line 529:     d = defaultdict(dict)
Line 530:     gateways = getRoutes()


-- 
To view, visit http://gerrit.ovirt.org/21652
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70379b24084fa8bec88425de9eca106e2a6ae8f0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list