Change in vdsm[master]: domainMonitor: notify on the first status check

fsimonce at redhat.com fsimonce at redhat.com
Mon Nov 25 16:43:15 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: domainMonitor: notify on the first status check
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

....................................................
File vdsm/storage/domainMonitor.py
Line 26: import misc
Line 27: from vdsm.config import config
Line 28: from sdc import sdCache
Line 29: 
Line 30: NOT_CHECKED_YET = 0
-1?
Line 31: 
Line 32: 
Line 33: class DomainMonitorStatus(object):
Line 34:     __slots__ = (


....................................................
File vdsm/storage/hsm.py
Line 1056:                 return
Line 1057: 
Line 1058:             pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng)
Line 1059:             if not hostID or not scsiKey or not msdUUID or not masterVersion:
Line 1060:                 hostID, scsiKey, msdUUID, masterVersion = pool.getPoolParams()
Register your callbacks here if you can (before and outside the connect API).
Line 1061:             res = pool.connect(hostID, scsiKey, msdUUID, masterVersion,
Line 1062:                                tuple(self.domainStateChangeCallbacks))
Line 1063:             if res:
Line 1064:                 self.pools[spUUID] = pool


....................................................
File vdsm/storage/sp.py
Line 665:         with open(self._poolFile, "w") as f:
Line 666:             f.writelines(pers)
Line 667: 
Line 668:     @unsecured
Line 669:     def connect(self, hostID, scsiKey, msdUUID, masterVersion, callbacks=()):
The callbacks for EIO should have never been part of this subsystem (storage). Even more they should not enter the API nor StoragePool.
Line 670:         """
Line 671:         Connect a Host to a specific storage pool.
Line 672: 
Line 673:         Caller must acquire resource Storage.spUUID so that this method would


-- 
To view, visit http://gerrit.ovirt.org/21649
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list