Change in vdsm[master]: sp: turn spm status attributes private

fsimonce at redhat.com fsimonce at redhat.com
Mon Nov 25 14:50:27 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: sp: turn spm status attributes private
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/storage/sp.py
Line 141:     def getSpmStatus(self):
Line 142:         return self._spmRole, self._getSpmLver(), self._getSpmId()
Line 143: 
Line 144:     @unsecured
Line 145:     def isSpmRoleAcquired(self):
I thought of using isSpmAcquired, but it sounded to me as if (with such name) it should return whether the SPM is acquired by *any* host in the cluster. What we return here is the current role of this host.
Line 146:         return self._spmRole == SPM_ACQUIRED
Line 147: 
Line 148:     @unsecured
Line 149:     def isSpmRoleFree(self):


-- 
To view, visit http://gerrit.ovirt.org/21527
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list