Change in vdsm[master]: vdsm: Hardware information about POWER hosts

ybronhei at redhat.com ybronhei at redhat.com
Sun Nov 24 16:47:36 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Hardware information about POWER hosts
......................................................................


Patch Set 3:

(1 comment)

....................................................
File lib/vdsm/ppc64HardwareInfo.py
Line 15: #
Line 16: # Refer to the README and COPYING files for full details of the license
Line 17: #
Line 18: 
Line 19: from vdsm import utils
why ? its a utility\package that unrelated to vdsm and might be used as external python package in the future. vdsm just uses it, exactly like dmidecode_util . I prefer all of those move to lib/vdsm, as ipwrapper, netinfo, libvirtconnection ... don't you agree?
Line 20: 
Line 21: import os
Line 22: 
Line 23: 


-- 
To view, visit http://gerrit.ovirt.org/19395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Better Saggi <bettersaggi at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list