Change in vdsm[master]: hsm: Rescan multipath before loading lvm cache

nsoffer at redhat.com nsoffer at redhat.com
Sat Nov 23 23:52:15 UTC 2013


Nir Soffer has uploaded a new change for review.

Change subject: hsm: Rescan multipath before loading lvm cache
......................................................................

hsm: Rescan multipath before loading lvm cache

lvm cache was loaded before multipath rescan, loading possibly stale
data, since existing devices may disappear and new devices may appear
after multipath rescan.  After lvm cache was loaded, storage domain
cache was refreshed, invoking multipath rescan and invalidating lvm
cache.  Later lvm commands would trigger a second load of the lvm cache.

This patch refreshes storage domain cache before loading lvm cache,
ensuring a fresh cache and saving an unneeded lvm cache reload, which
can be slow when having lot of lvs.

Change-Id: I6ec7beee1db193a47d9e8109929badfd5b322c02
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/21567/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 73f9f43..37d93c7 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -374,8 +374,8 @@
             self.log.warn("Failed to clean Storage Repository.", exc_info=True)
 
         def storageRefresh():
-            lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS)
             sdCache.refreshStorage()
+            lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS)
 
             fileUtils.createdir(self.tasksDir)
             # TBD: Should this be run in connectStoragePool? Should tasksDir


-- 
To view, visit http://gerrit.ovirt.org/21567
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ec7beee1db193a47d9e8109929badfd5b322c02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list