Change in vdsm[master]: netinfoTests: fix link info consistency and docstrings

asegurap at redhat.com asegurap at redhat.com
Sat Nov 23 20:01:25 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfoTests: fix link info consistency and docstrings
......................................................................


Patch Set 1:

(1 comment)

Good catch!

....................................................
File tests/netinfoTests.py
Line 154:                  'promiscuity 0  \\    dummy ',
Line 155:                  '419: jbond: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP> mtu '
Line 156:                  '1500 qdisc noqueue state UP mode DEFAULT group default \    '
Line 157:                  'link/ether 66:de:f1:da:aa:e7 brd ff:ff:ff:ff:ff:ff '
Line 158:                  'promiscuity 1 \    bond')
Darn, happens to me for copying from command line instead of from the python interpreter :(
Line 159:         return [ipwrapper.Link.fromText(line) for line in lines]
Line 160: 
Line 161:     def testNics(self):
Line 162:         """


-- 
To view, visit http://gerrit.ovirt.org/21564
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ae7289ebef4cb714f2c4ad2e541fc4580cfff48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list