Change in vdsm[master]: netinfo: Make get() use getLinks

danken at redhat.com danken at redhat.com
Sat Nov 23 18:10:08 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: netinfo: Make get() use getLinks
......................................................................


netinfo: Make get() use getLinks

By making get() use getLinks we avoid getLinks being called by nics
and by vlans, so it is all in all one less process creation and
less work to retrieve vlans and bridges as well.

For that to be possible we add the isBridge and isBond to ipwrapper.

Change-Id: Ia80df220cbf3d07fd229246748a0b0ebdcb302d2
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21563
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/ipwrapper.py
M lib/vdsm/netinfo.py
2 files changed, 13 insertions(+), 7 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21563
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia80df220cbf3d07fd229246748a0b0ebdcb302d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list