Change in vdsm[master]: ipwrapper: Move hidden bonds' nic logic from netinfo

danken at redhat.com danken at redhat.com
Sat Nov 23 09:20:04 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: ipwrapper: Move hidden bonds' nic logic from netinfo
......................................................................


ipwrapper: Move hidden bonds' nic logic from netinfo

This patch moves the remaining logic of what could hide a nic to
ipwrapper so that it is all well enclosed in a single digestible
method.

Since the nic master is retrieved from the ip links, that needs
a couple of tweaks in netinfoTests, namely:
- Adding the master information to the link line for the nics to
  be hidden. Which means that the tmpdir fixture is not necessary
  anymore.
- Monkeypatch the new Link info about existing bonds and the
  hidden config.

Change-Id: I5a49d7da35f8453b7297b0599db232867a4b1078
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21561
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/ipwrapper.py
M lib/vdsm/netinfo.py
M tests/netinfoTests.py
3 files changed, 27 insertions(+), 89 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a49d7da35f8453b7297b0599db232867a4b1078
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list