Change in vdsm[master]: netinfo: improvements from using Link devices

danken at redhat.com danken at redhat.com
Fri Nov 22 16:32:14 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: improvements from using Link devices
......................................................................


Patch Set 6: Code-Review-1

(3 comments)

....................................................
Commit Message
Line 10: 
Line 11: 1. Make get() retrieve all the links at once and aggregate
Line 12:    information from those links (instead of calling nics, bondings,
Line 13:    etc).
Line 14: 2. Add the needed convenience methos in ipwrapper's Link so (2) is
methos->methods
you probably mean "so (1) is much simpler".

But it would be simpler to just make this addition of convenience methods, and simplification of isHidden() in a separate patch...
Line 15:    much simpler.
Line 16: 3. Increase the consistency of the netinfo testsuite so that if we
Line 17:    were to use the master fields they would be correct and pointing to
Line 18:    an existent device.


Line 14: 2. Add the needed convenience methos in ipwrapper's Link so (2) is
Line 15:    much simpler.
Line 16: 3. Increase the consistency of the netinfo testsuite so that if we
Line 17:    were to use the master fields they would be correct and pointing to
Line 18:    an existent device.
existent->existing. improving the testsuit is honorable, but then again - a separate issue.
Line 19: 4. NET_PATH is not being used in netinfo anymore. Move it to
Line 20:    ipwrapper where it is used (otherwise pep8 would report error due
Line 21:    to unused constant.
Line 22: 


Line 15:    much simpler.
Line 16: 3. Increase the consistency of the netinfo testsuite so that if we
Line 17:    were to use the master fields they would be correct and pointing to
Line 18:    an existent device.
Line 19: 4. NET_PATH is not being used in netinfo anymore. Move it to
4 is not done, right?
Line 20:    ipwrapper where it is used (otherwise pep8 would report error due
Line 21:    to unused constant.
Line 22: 
Line 23: Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17


-- 
To view, visit http://gerrit.ovirt.org/21408
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list