Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...

asegurap at redhat.com asegurap at redhat.com
Fri Nov 22 15:35:37 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo/sampling: split speed into nic and bond specific methods
......................................................................


Patch Set 4:

(1 comment)

....................................................
File lib/vdsm/netinfo.py
Line 268:     """Returns the nic speed if it is a legal value and nicName refers to a
Line 269:     nic, 0 otherwise."""
Line 270:     try:
Line 271:         with open('/sys/class/net/%s/speed' % nicName) as speedFile:
Line 272:             s = int(speedFile.read())
True! I shouldn't remove these things.
Line 273:         if s not in (2 ** 16 - 1, 2 ** 32 - 1) or s > 0:
Line 274:             return s
Line 275:     except OSError as ose:
Line 276:         if ose.errno != errno.ENOENT:


-- 
To view, visit http://gerrit.ovirt.org/21542
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list