Change in vdsm[master]: ipwrapper Monitor: Move to using detailed oneline

danken at redhat.com danken at redhat.com
Fri Nov 22 13:46:13 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: ipwrapper Monitor: Move to using detailed oneline
......................................................................


Patch Set 5: Verified+1 Code-Review+2

(1 comment)

....................................................
File tests/ipwrapperTests.py
Line 189:         for text in bad_rules:
Line 190:             self.assertRaises(ValueError, Rule.fromText, text)
Line 191: 
Line 192:     def testMonitorEvents(self):
Line 193:         out = ('273: bond0: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc '
Frankly I prefer keeping qdisc with its value. But enough with nitpicking.
Line 194:                'noqueue state DOWN \\    link/ether 33:44:55:66:77:88 brd '
Line 195:                'ff:ff:ff:ff:ff:ff \n'
Line 196:                '4: wlp3s0: <BROADCAST,MULTICAST,UP,LOWER_UP> \\    '
Line 197:                'link/ether \n')


-- 
To view, visit http://gerrit.ovirt.org/21411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c593467d328c39654eae723126f889b51ff39d2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list