Change in vdsm[master]: gluster: Add force option to add brick command

barumuga at redhat.com barumuga at redhat.com
Fri Nov 22 01:57:12 UTC 2013


Bala.FA has posted comments on this change.

Change subject: gluster: Add force option to add brick command
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

....................................................
File vdsm/gluster/api.py
Line 109:         self.svdsmProxy.glusterVolumeReset(volumeName, option, force)
Line 110: 
Line 111:     @exportAsVerb
Line 112:     def volumeBrickAdd(self, volumeName, brickList,
Line 113:                        replicaCount=0, stripeCount=0, options=None):
add force option as like volumeRebalanceStart()
Line 114:         self.svdsmProxy.glusterVolumeAddBrick(volumeName,
Line 115:                                               brickList,
Line 116:                                               replicaCount,
Line 117:                                               stripeCount,


....................................................
File vdsm/gluster/cli.py
Line 551:     if replicaCount:
Line 552:         command += ["replica", "%s" % replicaCount]
Line 553:     command += brickList
Line 554:     if option:
Line 555:         command.append('force')
add force option as param.  for more detail look at volumeRebalanceStart()
Line 556:     try:
Line 557:         _execGlusterXml(command)
Line 558:         return True
Line 559:     except ge.GlusterCmdFailedException as e:


-- 
To view, visit http://gerrit.ovirt.org/21525
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I907e3798d2a360cfcfd736d7cf9cb8f43c95ca10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list