Change in vdsm[master]: vdsm: Accents in the vm name break the migration

danken at redhat.com danken at redhat.com
Thu Nov 21 15:56:13 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Accents in the vm name break the migration
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

....................................................
File vdsm/vm.py
Line 4876:         self._pathsPreparedEvent.wait(prepareTimeout)
Line 4877:         if not self._pathsPreparedEvent.isSet():
Line 4878:             self.log.debug('Timeout while waiting for path preparation')
Line 4879:             return False
Line 4880:         srcDomXML = self.conf.pop('_srcDomXML').encode('utf-8')
so you say that xmlrpclib automatically decodes utf-8-encoded strings into unicode?

(checking)

darn, you are right. xmlrpclib.dumps is not reversible.

 hi = '\xd7\xa9\xd7\x9c\xd7\x95\xd7\x9d'
 xmlrpclib.loads(xmlrpclib.dumps((hi,)))[0][0] == hi
 __main__:1: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
 False

and even json.dumps() has this. lovely.
Line 4881:         self._updateDevicesDomxmlCache(srcDomXML)
Line 4882: 
Line 4883:         for dev in self._customDevices():
Line 4884:             hooks.before_device_migrate_destination(


-- 
To view, visit http://gerrit.ovirt.org/19684
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9db5ea4f0745ef42633e3d265bcf40fb4733b2ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list