Change in vdsm[master]: vdsm: handle migration abort before semaphore acquiration

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Nov 21 15:39:52 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: handle migration abort before semaphore acquiration
......................................................................


Patch Set 3: Verified+1

Verification process:

To induce this issue I have created a hook before_vm_migrate_source:
-------
#!/usr/bin/python
import time
time.sleep(10)
-------

Now when you start a migration in the oVirt UI you click "Cancel Migration" as soon as the option becomes available. Due to the 10 second delay the cancellation is set before the call migrateToURI2 is issued, which is our problematic scenario we are trying to fix.

Before this patch we ended up with a destination VM waiting for the incoming migration, a source host with a stopped VM and the engine in a pretty strange state.

After this fix the migration is cancelled properly, the VM is still running after the aborting on the source host, and the destination server does not wait for an incoming migration.

-- 
To view, visit http://gerrit.ovirt.org/21445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id271a41466bc355ca505f764206457af419f0edd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list