Change in vdsm[master]: Report device to engine in a new fashion

amuller at redhat.com amuller at redhat.com
Thu Nov 21 09:03:12 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Report device to engine in a new fashion
......................................................................


Patch Set 3:

I've just been saddened to learn that dummy NICs cannot be used to test the new function. The alternative is to check if a default route exists in the main routing table, find an IP address that isn't routable via a local device and assert that the host must route to that address via its default gateway. However, I see very little merit in the test (I don't think it tests the function properly).

-- 
To view, visit http://gerrit.ovirt.org/21470
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icedb16c7f0bfccf05ffd2438e013e4894fda20da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list