Change in vdsm[master]: xmlrpc: Transport wrapper issue - vdsClient
didi at redhat.com
didi at redhat.com
Thu Nov 21 06:47:56 UTC 2013
Yedidyah Bar David has posted comments on this change.
Change subject: xmlrpc: Transport wrapper issue - vdsClient
......................................................................
Patch Set 1:
(1 comment)
....................................................
File lib/vdsm/vdscli.py.in
Line 161: raise Exception("No permission to read file: %s" % f)
Line 162:
Line 163: transport = TransportClass(key_file=KEYFILE,
Line 164: cert_file=CERTFILE, ca_certs=CACERT)
Line 165: TransportWrapper(transport)
And, may I add, as I do not know vdsm and can't help much with a real review, some time ago someone sent to engine-devel the following set of links about clean testable code, which I found very well-written:
http://lists.ovirt.org/pipermail/engine-devel/2013-August/005376.html
Line 166: server = xmlrpclib.ServerProxy('https://%s' % hostPort,
Line 167: transport)
Line 168: else:
Line 169: transport = SingleRequestTransport()
--
To view, visit http://gerrit.ovirt.org/21459
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4583a6c227fe500d370c877883ed9e570e021ae9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list