Change in vdsm[master]: Mark netinfoTests.testGetIfaceByIP as a broken test

danken at redhat.com danken at redhat.com
Wed Nov 20 15:59:51 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Mark netinfoTests.testGetIfaceByIP as a broken test
......................................................................


Patch Set 2:

Sorry for asking this only now, but wouldn't this break the function also in real life, making it return '' instead of Engine's iface?

-- 
To view, visit http://gerrit.ovirt.org/21471
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c30963f80bf13bc99a059232ec435c1672b2def
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list