Change in vdsm[master]: Makes getIfaceByIp return a set instead of a string

amuller at redhat.com amuller at redhat.com
Wed Nov 20 14:28:57 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Makes getIfaceByIp return a set instead of a string
......................................................................


Patch Set 2:

Now the test passes on hosts running python-ethtool-0.6-5.el6.x86_64.

I suggest we merge this in, then later work on a patch that actually deletes getIfaceByIP and its test (Since it only has one use which is no longer needed) and implement a new method that gets an IP and returns the device which is used to route to it. We then use that new method where getIfaceByIP is currently used (Call the new method on the destination IP of the socket).

-- 
To view, visit http://gerrit.ovirt.org/21197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie56ebc909d6a1ecd4218b11d680f49f85674717a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list