Change in vdsm[master]: Makes getIfaceByIp return a set instead of a string

asegurap at redhat.com asegurap at redhat.com
Wed Nov 20 14:11:50 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Makes getIfaceByIp return a set instead of a string
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/BindingXMLRPC.py
Line 88:         last = self.server.lastClient
Line 89:         lastserver = self.server.lastServerIP
Line 90:         return {'management_ip': self.serverIP,
Line 91:                 'lastClient': last,
Line 92:                 'lastClientIface': getIfaceByIP(lastserver).pop()}
The solution (coming in a following patchset) seems to be (in my opinion) to getIfaceByIPs(local, remote).

If the local ip is only on one device it returns that device. Otherwise it checks through which device the route local->remote should go.
Line 93: 
Line 94:     def _getKeyCertFilenames(self):
Line 95:         """
Line 96:         Get the locations of key and certificate files.


-- 
To view, visit http://gerrit.ovirt.org/21197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie56ebc909d6a1ecd4218b11d680f49f85674717a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list