Change in vdsm[ovirt-3.3]: Fail pre-start run after configure libvirt

ybronhei at redhat.com ybronhei at redhat.com
Mon Nov 18 10:43:23 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Fail pre-start run after configure libvirt
......................................................................


Patch Set 1:

(1 comment)

....................................................
File init/vdsmd_init_common.sh.in
Line 54: }
Line 55: 
Line 56: 
Line 57: task_reconfigure_libvirt(){
Line 58:     "$VDSM_TOOL" libvirt-configure | grep -q 'To start working' && return 1
I'm worried that it might reflects to backward usages, changing the return value is too bombastic
Line 59:     return 0
Line 60: }
Line 61: 
Line 62: 


-- 
To view, visit http://gerrit.ovirt.org/21356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list