Change in vdsm[master]: sampling.ImagePathStatus: drop unused code, and only it

danken at redhat.com danken at redhat.com
Sat Nov 16 11:50:27 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: sampling.ImagePathStatus: drop unused code, and only it
......................................................................


Patch Set 1:

(2 comments)

....................................................
File vdsm/sampling.py
Line 363:     """
Line 364:     AVERAGING_WINDOW = 5
Line 365:     SAMPLE_INTERVAL_SEC = 2
Line 366: 
Line 367:     def __init__(self, cif, log):
cif.irs is expected to transition from None to a real instance after the storage subsystem initializes itself (which can take a while).
Line 368:         self.startTime = time.time()
Line 369: 
Line 370:         threading.Thread.__init__(self)
Line 371:         self._log = log


Line 416:     def get(self):
Line 417:         stats = self._getInterfacesStats()
Line 418:         stats['cpuSysVdsmd'] = stats['cpuUserVdsmd'] = 0.0
Line 419:         stats['storageDomains'] = self._getStorageDomainsStats()
Line 420: 
it was, but I cannot defend its staying here.
Line 421:         now = time.time()
Line 422:         stats['elapsedTime'] = int(now - self.startTime)
Line 423:         if len(self._samples) < 2:
Line 424:             return stats


-- 
To view, visit http://gerrit.ovirt.org/21038
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I530b6d83c6ab5d0cc52df797ae3e40998fb77435
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list