Change in vdsm[master]: clientIF: Check device visibility on failed hotplugDisk

danken at redhat.com danken at redhat.com
Fri Nov 15 22:17:17 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: clientIF: Check device visibility on failed hotplugDisk
......................................................................


Patch Set 3:

(1 comment)

....................................................
Commit Message
Line 12: 
Line 13: The original fix failed to invoke multipath.rescan(), and the bug was
Line 14: verified by QE and used by customers for the last 6 month. We believe
Line 15: that the problem is a tiny race that is unlikely to happen, but it is
Line 16: possible and should be fixed.
I still do not understand how calling rescan() again can fix any race, more than a sleep() call can.
Line 17: 
Line 18: This patch implements the original fix in a different way, calling
Line 19: getDevicesVisibility(), which invokes multipath.rescan() if a device is
Line 20: missing.


-- 
To view, visit http://gerrit.ovirt.org/21181
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list